linux-kernel - Re: [GIT PULL] More Kbuild updates for v5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Sep 2019 12:59:24 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        masahiroy@...nel.org
Subject: Re: [GIT PULL] More Kbuild updates for v5.4-rc1

Hi Linus,

On Sun, Sep 29, 2019 at 11:57 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sat, Sep 28, 2019 at 11:41 AM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
> >
> > Please pull some more updates for v5.4-rc1
>
> I pulled this, but I'm not sure if I'm going to keep it.
>
> There's thousands of lines of changes because of the header-test-y
> thing, and I'm honestly considering just getting rid of that thing
> entirely.
>
> It has no actual upside that I can tell, and it's extremely annoying.
> It pollutes the tree with hundreds of *.h.s files, which messes up
> filename completion, and just generally is ugly and annoying.
>
> So I've unpulled for now, and I'm not sure I want to pull more noise
> for this mis-feature.
>
>                 Linus




The concept of header test is to make sure every header
is self-contained, so that headers can be included in
  either
#include <linux/foo.h>
#include <linux/bar.h>
  or
#include <linux/bar.h>
#include <linux/foo.h>


Of course, you can argue that it is addressing hypothetical issues
"what if the include directives are arranged in this order?",
that nobody has been hit before.

If this test is just annoying, shall we remove
the 'header-test-y' syntax and include/Kbuild entirely?

But, at least, I want to continue compile-testing
uapi headers that are exported to user-space.

This is useful to detect a broken uapi header
that is never be able to be compiled in user-space.

For example,
https://lkml.org/lkml/2019/6/19/104


So, I'd like to keep usr/include/Makefile
at least.


-- 
Best Regards
Masahiro Yamada