linux-kernel - Re: [PATCH AUTOSEL 5.2 17/42] MIPS: lantiq: update the clock alias' for the mainline PCIe PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe9161b3-2402-e5a8-959b-63c807be3e08@hauke-m.de>
Date:   Sun, 29 Sep 2019 19:39:49 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Paul Burton <paul.burton@...s.com>, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org, john@...ozen.org, kishon@...com,
        ralf@...ux-mips.org, robh+dt@...nel.org, mark.rutland@....com,
        ms@....tdt.de
Subject: Re: [PATCH AUTOSEL 5.2 17/42] MIPS: lantiq: update the clock alias'
 for the mainline PCIe PHY driver

On 9/29/19 7:32 PM, Sasha Levin wrote:
> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> [ Upstream commit ed90302be64a53d9031c8ce05428c358b16a5d96 ]
> 
> The mainline PCIe PHY driver has it's own devicetree node. Update the
> clock alias so the mainline driver finds the clocks.
> 
> The first PCIe PHY is located at 0x1f106800 and exists on VRX200, ARX300
> and GRX390.
> The second PCIe PHY is located at 0x1f700400 and exists on ARX300 and
> GRX390.
> The third PCIe PHY is located at 0x1f106a00 and exists onl on GRX390.
> Lantiq's board support package (called "UGW") names these registers
> "PDI".
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Paul Burton <paul.burton@...s.com>
> Cc: linux-mips@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Cc: john@...ozen.org
> Cc: kishon@...com
> Cc: ralf@...ux-mips.org
> Cc: robh+dt@...nel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: hauke@...ke-m.de
> Cc: mark.rutland@....com
> Cc: ms@....tdt.de
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  arch/mips/lantiq/xway/sysctrl.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Hi Sasha,

This change only makes sense with the new upstream PCIe phy driver which
was added to kernel 5.4 [0], older kernel versions do not have this PCIe
PHY driver. I would not backport these changes to older kernel versions.

[0]: https://git.kernel.org/linus/e52a632195bf43d1a91ae699e7536a6ead736aa7

Hauke



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)