linux-kernel - Re: [PATCH 2/3] perf jevents: Fix period for Intel fixed counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190930105033.GE9622@kernel.org>
Date:   Mon, 30 Sep 2019 07:50:33 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/3] perf jevents: Fix period for Intel fixed counters

Em Fri, Sep 27, 2019 at 04:35:45PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The Intel fixed counters use a special table to override the JSON
> information. During this override the period information from
> the JSON file got dropped, which results in inst_retired.any
> and similar running with frequency mode instead of a period.
> Just specify the expected period in the table.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/perf/pmu-events/jevents.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index d413761621b0..fa85e33762f7 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -449,12 +449,12 @@ static struct fixed {
>  	const char *name;
>  	const char *event;
>  } fixed[] = {
> -	{ "inst_retired.any", "event=0xc0" },
> -	{ "inst_retired.any_p", "event=0xc0" },
> -	{ "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
> -	{ "cpu_clk_unhalted.thread", "event=0x3c" },
> -	{ "cpu_clk_unhalted.core", "event=0x3c" },
> -	{ "cpu_clk_unhalted.thread_any", "event=0x3c,any=1" },
> +	{ "inst_retired.any", "event=0xc0,period=2000003" },
> +	{ "inst_retired.any_p", "event=0xc0,period=2000003" },
> +	{ "cpu_clk_unhalted.ref", "event=0x0,umask=0x03,period=2000003" },
> +	{ "cpu_clk_unhalted.thread", "event=0x3c,period=2000003" },
> +	{ "cpu_clk_unhalted.core", "event=0x3c,period=2000003" },
> +	{ "cpu_clk_unhalted.thread_any", "event=0x3c,any=1,period=2000003" },
>  	{ NULL, NULL},
>  };
>  
> -- 
> 2.21.0

-- 

- Arnaldo