linux-kernel - Re: [PATCH 4/5] ASoC: amd: added pmops for pci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87475117-31f9-ac80-58c6-7db384e805f4@amd.com>
Date:   Mon, 30 Sep 2019 11:30:28 +0000
From:   vishnu <vravulap@....com>
To:     Mark Brown <broonie@...nel.org>,
        "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>
CC:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@....com>,
        Colin Ian King <colin.king@...onical.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] ASoC: amd: added pmops for pci driver

Hi Mark,

Thanks for your suggestions.
Please ignore all the patches.I will address all the inputs shared by 
you and resend them.

Thanks,
Vishnu

On 26/09/19 11:54 PM, Mark Brown wrote:
> On Fri, Sep 27, 2019 at 04:37:38AM +0530, Ravulapati Vishnu vardhan rao wrote:
> 
>> +static int  snd_acp3x_suspend(struct device *dev)
>> +{
>> +	return 0;
>> +}
>> +
>> +static int  snd_acp3x_resume(struct device *dev)
>> +{
>> +	return 0;
>> +}
>> +
>> +static const struct dev_pm_ops acp3x_pm = {
>> +	.runtime_suspend = snd_acp3x_suspend,
>> +	.runtime_resume =  snd_acp3x_resume,
>> +	.resume	=	snd_acp3x_resume,
>> +
>> +};
> 
> These operations are empty so they should just be removed.
>