linux-kernel - Re: [PATCH] watchdog/sbc7240_wdt: Fix yet another -Wimplicit-fallthrough warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Sep 2019 06:13:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Borislav Petkov <bp@...en8.de>, LKML <linux-kernel@...r.kernel.org>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog/sbc7240_wdt: Fix yet another
 -Wimplicit-fallthrough warning

On 9/29/19 4:46 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> ... by moving the fall through comment outside of the code block so that
> gcc sees it.
> 
> No functional changes.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-watchdog@...r.kernel.org

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/sbc7240_wdt.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/sbc7240_wdt.c b/drivers/watchdog/sbc7240_wdt.c
> index 12cdee7d5069..90d67e6d8e8b 100644
> --- a/drivers/watchdog/sbc7240_wdt.c
> +++ b/drivers/watchdog/sbc7240_wdt.c
> @@ -194,9 +194,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>   
>   		if (wdt_set_timeout(new_timeout))
>   			return -EINVAL;
> -
> -		/* Fall through */
>   	}
> +	/* Fall through */
>   	case WDIOC_GETTIMEOUT:
>   		return put_user(timeout, (int __user *)arg);
>   	default:
>