linux-kernel - Re: [PATCH v8 7/8] media: v4l2-ctrl: Add new helper v4l2_ctrl_ptr_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Sep 2019 15:50:25 +0200
From:   Ricardo Ribalda Delgado <ribalda@...nel.org>
To:     Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Jacopo Mondi <jacopo@...ndi.org>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH v8 7/8] media: v4l2-ctrl: Add new helper v4l2_ctrl_ptr_from_void

Hi Hans

Thanks for the review

On Mon, Sep 30, 2019 at 3:07 PM Hans Verkuil <hverkuil-cisco@...all.nl> wrote:
>
> On 9/30/19 12:18 PM, Ricardo Ribalda Delgado wrote:
> > This helper function simplifies the code by not needing a union
> > v4l2_ctrl_ptr and an assignment every time we need to use
> > a ctrl_ptr.
> >
> > Suggested-by: Hans Verkuil <hverkuil@...all.nl>
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@...nel.org>
> > ---
> >  include/media/v4l2-ctrls.h | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> > index c42f164e2c9e..d69cfdffd41d 100644
> > --- a/include/media/v4l2-ctrls.h
> > +++ b/include/media/v4l2-ctrls.h
> > @@ -73,6 +73,17 @@ union v4l2_ctrl_ptr {
> >       void *p;
> >  };
> >
> > +/**
> > + * v4l2_ctrl_ptr() - Helper function to return a v4l2_ctrl_ptr from a
> > + * void pointer
> > + * @ptr:     The void pointer
> > + */
> > +static inline union v4l2_ctrl_ptr v4l2_ctrl_ptr_from_void(void *ptr)
>
> Mismatch between function name and the comment above.
>
> But _from_void is not a good name, since it's from a void pointer.
>
> How about: v4l2_ctrl_ptr_create(void *ptr)
>
> since you create a v4l2_ctrl_ptr.
>
> Regards,
>
>         Hans

After talking on IRC:

Will fix both changes and resend v9 after v5.4-rc1 is merged back into
the media tree.

Thanks again!

>
> > +{
> > +     BUILD_BUG_ON(sizeof(union v4l2_ctrl_ptr) != sizeof(void *));
> > +     return (union v4l2_ctrl_ptr) ptr;
> > +}
> > +
> >  /**
> >   * struct v4l2_ctrl_ops - The control operations that the driver has to provide.
> >   *
> >
>