linux-kernel - Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190929145758.GA2017443@kroah.com>
Date:   Sun, 29 Sep 2019 16:57:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jesse Barton <jessebarton95@...il.com>
Cc:     valdis.kletnieks@...edu, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase
 coding style issue

On Sun, Sep 29, 2019 at 09:50:57AM -0500, Jesse Barton wrote:
> Changed function names:
> ffsUmountVol to ffs_umount_vol
> ffsMountVol to ffs_mount_vol
> ffsSyncVol to ffs_sync_vol
> 
> 

That says _what_ you did, but not _why_ you are doing this.

And is this really the best name for these functions?  Why the ffs_*
prefix?

Also, you didn't include the maintainer again, and you didn't thread
your emails using 'git send-email' :(

And finally, you sent a new version of the patch, but did not "version"
it, saying what changed from the previous version.  The documentation
says how to do this, so you might want to re-read that.

Can you please fix this all up and resend the series as "v3"?

thanks,

greg k-h