linux-kernel - Re: [PATCH] perf: rework memory accounting in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <663F4E97-531B-4B5F-A562-E28D6D20BCD4@fb.com>
Date:   Mon, 30 Sep 2019 05:33:52 +0000
From:   Song Liu <songliubraving@...com>
To:     Hechao Li <hechaol@...com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Kernel Team <Kernel-team@...com>, Jie Meng <jmeng@...com>
Subject: Re: [PATCH] perf: rework memory accounting in perf_mmap()



> On Sep 16, 2019, at 1:10 PM, Hechao Li <hechaol@...com> wrote:
> 
> Song Liu <songliubraving@...com> wrote on Mon [2019-Sep-16 12:43:16 -0700]:
>> Hi Peter,
>> 
>>> On Sep 4, 2019, at 2:46 PM, Song Liu <songliubraving@...com> wrote:
>>> 
>>> perf_mmap() always increases user->locked_vm. As a result, "extra" could
>>> grow bigger than "user_extra", which doesn't make sense. Here is an
>>> example case:
>>> 
>>> Note: Assume "user_lock_limit" is very small.
>>> | # of perf_mmap calls |vma->vm_mm->pinned_vm|user->locked_vm|
>>> | 0                    | 0                   | 0             |
>>> | 1                    | user_extra          | user_extra    |
>>> | 2                    | 3 * user_extra      | 2 * user_extra|
>>> | 3                    | 6 * user_extra      | 3 * user_extra|
>>> | 4                    | 10 * user_extra     | 4 * user_extra|
>>> 
>>> Fix this by maintaining proper user_extra and extra.
>>> 
>>> Reported-by: Hechao Li <hechaol@...com>
>>> Cc: Jie Meng <jmeng@...com>
>>> Cc: Peter Zijlstra <peterz@...radead.org>
>>> Signed-off-by: Song Liu <songliubraving@...com>
>> 
>> Could you please share your feedbacks/comments on this one?
>> 
>> Thanks,
>> Song
> 
> The change looks good to me. Thanks, Song.
> 
> Reviewed-By: Hechao Li <hechaol@...com>

Thanks Hechao!

Hi Peter, 

Does this fix look good to you?

Thanks,
Song