linux-kernel - Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190930185918.GA18431@bogus>
Date:   Mon, 30 Sep 2019 13:59:18 -0500
From:   Rob Herring <robh@...nel.org>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
        brendanhiggins@...gle.com, joel@....id.au, andrew@...id.au,
        mark.rutland@....com, benh@...nel.crashing.org
Subject: Re: [PATCH 2/2] dt-bindings: i2c: Aspeed: Add AST2600 compatible

On Fri, Sep 13, 2019 at 11:35:10AM -0500, Eddie James wrote:
> Document the AST2600 I2C bus compatible string.
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> index 8fbd863..b47f6cc 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> @@ -1,4 +1,4 @@
> -Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs.
> +Device tree configuration for the I2C busses on the AST24XX, AST25XX, and AST26XX SoCs.

Perhaps s/buses/busses/ while you're here.

Acked-by: Rob Herring <robh@...nel.org>

>  
>  Required Properties:
>  - #address-cells	: should be 1
> @@ -6,6 +6,7 @@ Required Properties:
>  - reg			: address offset and range of bus
>  - compatible		: should be "aspeed,ast2400-i2c-bus"
>  			  or "aspeed,ast2500-i2c-bus"
> +			  or "aspeed,ast2600-i2c-bus"
>  - clocks		: root clock of bus, should reference the APB
>  			  clock in the second cell
>  - resets		: phandle to reset controller with the reset number in
> -- 
> 1.8.3.1
>