linux-kernel - Re: [PATCH v2 2/5] dt-bindings: Document brcm,irq-can-wake for brcm,bcm7038-l1-intc.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Sep 2019 14:05:49 -0500
From:   Rob Herring <robh@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Cernekee <cernekee@...il.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:BROADCOM BMIPS MIPS ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:BROADCOM BMIPS MIPS ARCHITECTURE" 
        <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: Document brcm,irq-can-wake for
 brcm,bcm7038-l1-intc.txt

On Fri, Sep 13, 2019 at 12:15:39PM -0700, Florian Fainelli wrote:
> The BCM7038 L1 interrupt controller can be used as a wake-up interrupt
> controller on MIPS and ARM-based systems, document the brcm,irq-can-wake
> which has been "standardized" across Broadcom interrupt controllers.

Not clear that that got much review...

We have a defined way to indicate wakeup sources (which maybe didn't 
exist in 2014), why can't that be used? If a device can wakeup the 
system, I'd think we can just assume that the parent interrupt 
controller(s) can support that.

In any case, I'm not going to stand in the way of this:

Acked-by: Rob Herring <robh@...nel.org>

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt   | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
> index 2117d4ac1ae5..4eb043270f5b 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
> @@ -31,6 +31,11 @@ Required properties:
>  - interrupts: specifies the interrupt line(s) in the interrupt-parent controller
>    node; valid values depend on the type of parent interrupt controller
>  
> +Optional properties:
> +
> +- brcm,irq-can-wake: If present, this means the L1 controller can be used as a
> +  wakeup source for system suspend/resume.
> +
>  If multiple reg ranges and interrupt-parent entries are present on an SMP
>  system, the driver will allow IRQ SMP affinity to be set up through the
>  /proc/irq/ interface.  In the simplest possible configuration, only one
> -- 
> 2.17.1
>