linux-kernel - Re: [PATCH] dimlib: make DIMLIB a hidden symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUs8oqDgYpQdu_bJ1Hvz+Lq_qPXLvuKj7=H=6818OM9=A@mail.gmail.com>
Date:   Mon, 30 Sep 2019 21:34:05 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Tal Gilboa <talgi@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol

Hi Uwe, Tal,

On Sat, Sep 21, 2019 at 7:50 PM Uwe Kleine-König <uwe@...ine-koenig.org> wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
>
> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>

Thanks for your patch!

> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>           Implementation is done using GnuPG MPI library
>
>  config DIMLIB
> -       bool "DIM library"
> -       default y
> +       bool
>         help
>           Dynamic Interrupt Moderation library.
>           Implements an algorithm for dynamically change CQ moderation values

Thanks for fixing the first issue!

The second issue is still present: NET_VENDOR_BROADCOM (which defaults
to y, as all other NET_VENDOR_* symbols) should only be a gatekeeper for
the various Broadcom network driver config options, and should not select
DIMLIB.

Cfr. my earlier complaint in
https://lore.kernel.org/linux-rdma/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds