linux-kernel - Re: [PATCH] firmware: google: increment VPD key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d928104.1c69fb81.29df9.6eef@mx.google.com>
Date:   Mon, 30 Sep 2019 15:26:11 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Brian Norris <briannorris@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        Hung-Te Lin <hungte@...omium.org>,
        Brian Norris <briannorris@...omium.org>,
        stable@...r.kernel.org, Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] firmware: google: increment VPD key_len properly

Quoting Brian Norris (2019-09-30 14:45:22)
> Commit 4b708b7b1a2c ("firmware: google: check if size is valid when
> decoding VPD data") adds length checks, but the new vpd_decode_entry()
> function botched the logic -- it adds the key length twice, instead of
> adding the key and value lengths separately.
> 
> On my local system, this means vpd.c's vpd_section_create_attribs() hits
> an error case after the first attribute it parses, since it's no longer
> looking at the correct offset. With this patch, I'm back to seeing all
> the correct attributes in /sys/firmware/vpd/...
> 
> Fixes: 4b708b7b1a2c ("firmware: google: check if size is valid when decoding VPD data")
> Cc: <stable@...r.kernel.org>
> Cc: Hung-Te Lin <hungte@...omium.org>
> Cc: Guenter Roeck <groeck@...omium.org>
> Cc: Stephen Boyd <swboyd@...omium.org>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>