linux-kernel - Re: [PATCH] PCI/switchtec: read all 64bits of part_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190930223746.GA216949@google.com>
Date:   Mon, 30 Sep 2019 17:37:46 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Doug Meyer <dmeyer@...aio.com>,
        Kelvin Cao <Kelvin.Cao@...rochip.com>
Subject: Re: [PATCH] PCI/switchtec: read all 64bits of part_event_bitmap

On Tue, Sep 10, 2019 at 01:58:33PM -0600, Logan Gunthorpe wrote:
> The part_event_bitmap register is 64 bits wide and should be read with
> ioread64 instead of the 32-bit ioread32.
> 
> Reported-by: Doug Meyer <dmeyer@...aio.com>
> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Kelvin Cao <Kelvin.Cao@...rochip.com>

Applied to pci/switchtec for v5.5, thanks!

I added:

  Fixes: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
  Cc: stable@...r.kernel.org      # v4.12+

Object if you don't want those.

> ---
>  drivers/pci/switch/switchtec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index 8c94cd3fd1f2..465d6afd826e 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -675,7 +675,7 @@ static int ioctl_event_summary(struct switchtec_dev *stdev,
>  		return -ENOMEM;
>  
>  	s->global = ioread32(&stdev->mmio_sw_event->global_summary);
> -	s->part_bitmap = ioread32(&stdev->mmio_sw_event->part_event_bitmap);
> +	s->part_bitmap = ioread64(&stdev->mmio_sw_event->part_event_bitmap);
>  	s->local_part = ioread32(&stdev->mmio_part_cfg->part_event_summary);
>  
>  	for (i = 0; i < stdev->partition_count; i++) {
> -- 
> 2.20.1
>