linux-kernel - Re: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190930224838.GA27522@bogus>
Date:   Mon, 30 Sep 2019 17:48:38 -0500
From:   Rob Herring <robh@...nel.org>
To:     Biwen Li <biwen.li@....com>
Cc:     'Geert Uytterhoeven' <geert@...ux-m68k.org>,
        Mark Rutland <mark.rutland@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Sam Ravnborg <sam@...nborg.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit

On Tue, Sep 17, 2019 at 08:25:55AM +0000, Biwen Li wrote:
> > 
> > Caution: EXT Email
> > 
> > Hi Biwen,
> > 
> > On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@....com> wrote:
> > > The patch adds kohms unit
> > >
> > > Signed-off-by: Biwen Li <biwen.li@....com>
> > 
> > Thanks for your patch!
> > 
> > > --- a/Documentation/devicetree/bindings/property-units.txt
> > > +++ b/Documentation/devicetree/bindings/property-units.txt
> > > @@ -27,6 +27,7 @@ Electricity
> > >  -microamp      : microampere
> > >  -microamp-hours : microampere hour
> > >  -ohms          : ohm
> > > +-kohms         : kiloohm
> > >  -micro-ohms    : microohm
> > >  -microwatt-hours: microwatt hour
> > >  -microvolt     : microvolt
> > 
> > What's your rationale for adding "kohms"?
> > Do you need to specify resistance values that do not fit in 32-bit, and thus
> 32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> > cannot be specified using "ohms"?
> If replace with ohms, the value is as follows:
> 60000 ohm, 100000 ohm, 500000 ohm.
> It's so long for everyone.

It's not any longer, it's still 32-bits.

Please stick with '-ohms'.

Rob