linux-kernel - [PATCH] scatterlist: Comment on pages for sg_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1569954770-11477-1-git-send-email-alan.mikhak@sifive.com>
Date:   Tue,  1 Oct 2019 11:32:50 -0700
From:   Alan Mikhak <alan.mikhak@...ive.com>
To:     linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
        alexios.zavras@...el.com, ming.lei@...hat.com,
        gregkh@...uxfoundation.org, tglx@...utronix.de, jgg@...pe.ca,
        christophe.leroy@....fr, thellstrom@...are.com,
        galpress@...zon.com, palmer@...ive.com, paul.walmsley@...ive.com
Cc:     Alan Mikhak <alan.mikhak@...ive.com>
Subject: [PATCH] scatterlist: Comment on pages for sg_set_page()

From: Alan Mikhak <alan.mikhak@...ive.com>

Update the description of sg_set_page() to communicate current
requirements for the page pointer parameter.

Signed-off-by: Alan Mikhak <alan.mikhak@...ive.com>
---
 include/linux/scatterlist.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
index 6eec50fb36c8..6dda865893aa 100644
--- a/include/linux/scatterlist.h
+++ b/include/linux/scatterlist.h
@@ -112,6 +112,12 @@ static inline void sg_assign_page(struct scatterlist *sg, struct page *page)
  *   of the page pointer. See sg_page() for looking up the page belonging
  *   to an sg entry.
  *
+ *   Scatterlist currently expects the page parameter to be a pointer to
+ *   a page that is backed by a page struct.
+ *
+ *   Page pointers derived from addresses obtained from ioremap() are
+ *   currently not supported since they require use of iomem safe memcpy.
+ *
  **/
 static inline void sg_set_page(struct scatterlist *sg, struct page *page,
 			       unsigned int len, unsigned int offset)
-- 
2.7.4