linux-kernel - Re: [PATCH 3/5] leds: flash: Remove extern from the header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6601fe9-0723-baec-d610-aafe7731c80d@gmail.com>
Date:   Tue, 1 Oct 2019 22:57:26 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, pavel@....cz
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] leds: flash: Remove extern from the header file

Dan,

Thank you for the patch.

Could we have similar patch for leds.h when we are at it,
if you wouldn't mind?

-- 
Best regards,
Jacek Anaszewski

On 10/1/19 8:04 PM, Dan Murphy wrote:
> extern is implied and is not needed in the header file.
> Remove the extern keyword and re-align the code.
> 
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
>  include/linux/led-class-flash.h | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h
> index 7ff287a9e2a2..1bd83159fa4c 100644
> --- a/include/linux/led-class-flash.h
> +++ b/include/linux/led-class-flash.h
> @@ -94,12 +94,12 @@ static inline struct led_classdev_flash *lcdev_to_flcdev(
>   *
>   * Returns: 0 on success or negative error value on failure
>   */
> -extern int led_classdev_flash_register_ext(struct device *parent,
> -					struct led_classdev_flash *fled_cdev,
> -					struct led_init_data *init_data);
> +int led_classdev_flash_register_ext(struct device *parent,
> +				    struct led_classdev_flash *fled_cdev,
> +				    struct led_init_data *init_data);
>  
>  static inline int led_classdev_flash_register(struct device *parent,
> -					struct led_classdev_flash *fled_cdev)
> +					   struct led_classdev_flash *fled_cdev)
>  {
>  	return led_classdev_flash_register_ext(parent, fled_cdev, NULL);
>  }
> @@ -111,7 +111,7 @@ static inline int led_classdev_flash_register(struct device *parent,
>   *
>   * Unregister a previously registered via led_classdev_flash_register object
>   */
> -extern void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev);
> +void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev);
>  
>  /**
>   * led_set_flash_strobe - setup flash strobe
> @@ -159,8 +159,8 @@ static inline int led_get_flash_strobe(struct led_classdev_flash *fled_cdev,
>   *
>   * Returns: 0 on success or negative error value on failure
>   */
> -extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
> -					u32 brightness);
> +int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
> +			     u32 brightness);
>  
>  /**
>   * led_update_flash_brightness - update flash LED brightness
> @@ -171,7 +171,7 @@ extern int led_set_flash_brightness(struct led_classdev_flash *fled_cdev,
>   *
>   * Returns: 0 on success or negative error value on failure
>   */
> -extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
> +int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
>  
>  /**
>   * led_set_flash_timeout - set flash LED timeout
> @@ -182,8 +182,7 @@ extern int led_update_flash_brightness(struct led_classdev_flash *fled_cdev);
>   *
>   * Returns: 0 on success or negative error value on failure
>   */
> -extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev,
> -					u32 timeout);
> +int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, u32 timeout);
>  
>  /**
>   * led_get_flash_fault - get the flash LED fault
> @@ -194,7 +193,6 @@ extern int led_set_flash_timeout(struct led_classdev_flash *fled_cdev,
>   *
>   * Returns: 0 on success or negative error value on failure
>   */
> -extern int led_get_flash_fault(struct led_classdev_flash *fled_cdev,
> -					u32 *fault);
> +int led_get_flash_fault(struct led_classdev_flash *fled_cdev, u32 *fault);
>  
>  #endif	/* __LINUX_FLASH_LEDS_H_INCLUDED */
>