linux-kernel - Re: [PATCH] md/raid0: Fix an error message in raid0_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW7zfwX2GPEhXV_X5F7zKi-NvT0vmP-bCc9qYjmFwSJwFg@mail.gmail.com>
Date:   Tue, 1 Oct 2019 16:08:54 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     NeilBrown <neilb@...e.de>, linux-raid <linux-raid@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] md/raid0: Fix an error message in raid0_make_request()

On Fri, Sep 20, 2019 at 11:00 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> The first argument to WARN() is supposed to be a condition.  The
> original code will just print the mdname() instead of the full warning
> message.
>
> Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  drivers/md/raid0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index f61693e59684..3956ea502f97 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -615,7 +615,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio)
>                 tmp_dev = map_sector(mddev, zone, sector, &sector);
>                 break;
>         default:
> -               WARN("md/raid0:%s: Invalid layout\n", mdname(mddev));
> +               WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev));
>                 bio_io_error(bio);
>                 return true;

Applied. Thanks for the fix!

Song