linux-kernel - Re: [PATCH v2] spi: gpio: prevent memory leak in spi_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b55e753-5797-2bdc-fae6-f575a0ef8186@web.de>
Date:   Tue, 1 Oct 2019 11:11:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-spi@...r.kernel.org
Cc:     Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <smccaman@....edu>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] spi: gpio: prevent memory leak in spi_gpio_probe

> … In order to avoid leak spi_contriller_put must
> be called in case of failure for devm_add_action_or_reset.

How does this wording fit to the diff display that you would like
to add the function call “spi_master_put(master)” in
one if branch?


> Fixes: 8b797490b4db ("spi: gpio: Make sure spi_master_put() is called in every error path")

Is there a need to complete the corresponding exception handling
at any more source code places?

Regards,
Markus