linux-kernel - Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3b41a7b-ef3b-7960-13a1-d4b8dd6f15b6@tronnes.org>
Date:   Tue, 1 Oct 2019 12:58:00 +0200
From:   Noralf Trønnes <noralf@...nnes.org>
To:     Ulf Magnusson <ulfalizer@...il.com>, linux-kbuild@...r.kernel.org,
        yamada.masahiro@...ionext.com
Cc:     airlied@...ux.ie, daniel@...ll.ch, sam@...nborg.org,
        david@...hnology.com, hdegoede@...hat.com, eric@...olt.net,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from
 TINYDRM_REPAPER



Den 27.09.2019 19.42, skrev Ulf Magnusson:
> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's
> option") changed the type of THERMAL from tristate to bool, so
> THERMAL || !THERMAL is now always y. Remove the redundant dependency.
> 
> Discovered through Kconfiglib detecting a dependency loop. The C tools
> simplify the expression to y before running dependency loop detection,
> and so don't see it. Changing the type of THERMAL back to tristate makes
> the C tools detect the same loop.
> 
> Not sure if running dep. loop detection after simplification can be
> called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at
> least.
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---

Thanks, applied to drm-misc-next.

Noralf.