linux-kernel - Re: [PATCH] mm: fix struct member name in function comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191001115223.tqalvsgu6wjm36sb@master>
Date:   Tue, 1 Oct 2019 11:52:23 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Hao Lee <haolee.swjtu@...il.com>
Cc:     akpm@...ux-foundation.org, vbabka@...e.cz,
        dan.j.williams@...el.com, mhocko@...e.com,
        mgorman@...hsingularity.net, richard.weiyang@...il.com,
        hannes@...xchg.org, arunks@...eaurora.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fix struct member name in function comments

On Fri, Sep 27, 2019 at 02:40:49PM +0000, Hao Lee wrote:
>The member in struct zonelist is _zonerefs instead of zones.
>
>Signed-off-by: Hao Lee <haolee.swjtu@...il.com>

Reviewed-by: Wei Yang <richardw.yang@...ux.intel.com>

>---
> include/linux/mmzone.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
>index 3f38c30d2f13..6d44a49b3f29 100644
>--- a/include/linux/mmzone.h
>+++ b/include/linux/mmzone.h
>@@ -1064,7 +1064,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
> /**
>  * for_each_zone_zonelist_nodemask - helper macro to iterate over valid zones in a zonelist at or below a given zone index and within a nodemask
>  * @zone - The current zone in the iterator
>- * @z - The current pointer within zonelist->zones being iterated
>+ * @z - The current pointer within zonelist->_zonerefs being iterated
>  * @zlist - The zonelist being iterated
>  * @highidx - The zone index of the highest zone to return
>  * @nodemask - Nodemask allowed by the allocator
>-- 
>2.14.5

-- 
Wei Yang
Help you, Help me