linux-kernel - Re: [PATCH mmotm] sparc64: pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Oct 2019 13:53:48 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens

On Tue, Oct 1, 2019 at 2:23 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix lib-untag-user-pointers-in-strn_user.patch unmatched left paren.
> Fixes many of these build errors:
>
> ../mm/gup.c: In function '__get_user_pages':
> ../mm/gup.c:791:30: error: expected ')' before ';' token
>   start = untagged_addr(start);
>                               ^
> In file included from ../arch/sparc/include/asm/pgtable.h:5,
>                  from ../include/linux/mm.h:99,
>                  from ../mm/gup.c:7:
> ../arch/sparc/include/asm/pgtable_64.h:1102:2: note: to match this '('
>   ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
>   ^
> ../mm/gup.c:791:10: note: in expansion of macro 'untagged_addr'
>   start = untagged_addr(start);
>           ^~~~~~~~~~~~~
> ../mm/gup.c:892:21: error: expected ';' before '}' token
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Andrey Konovalov <andreyknvl@...gle.com>
> ---
>
> Is this already fixed???

Hi Randy,

Yes, this has been fixed by a22fea94992a2bc5328005e62f368413ede49c14.

Thanks!

>
>
>  arch/sparc/include/asm/pgtable_64.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm-2019-0925-1810.orig/arch/sparc/include/asm/pgtable_64.h
> +++ mmotm-2019-0925-1810/arch/sparc/include/asm/pgtable_64.h
> @@ -1099,7 +1099,7 @@ static inline unsigned long __untagged_a
>         return start;
>  }
>  #define untagged_addr(addr) \
> -       ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
> +       ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))))
>
>  static inline bool pte_access_permitted(pte_t pte, bool write)
>  {
>