linux-kernel - Re: [PATCH] Staging: fbtft: fix memory leak in fbtft_framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191001133408.GG22609@kadam>
Date:   Tue, 1 Oct 2019 16:34:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     Jan Sebastian Götte <linux@...eg.net>,
        devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org,
        Nishad Kamdar <nishadkamdar@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kjlu@....edu,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...ll.ch>, emamd001@....edu,
        Bhanusree Pola <bhanusreemahesh@...il.com>, smccaman@....edu,
        Phil Reid <preid@...ctromag.com.au>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH] Staging: fbtft: fix memory leak in
 fbtft_framebuffer_alloc

On Sun, Sep 29, 2019 at 10:09:45PM -0500, Navid Emamdoost wrote:
> In fbtft_framebuffer_alloc the error handling path should take care of
> releasing frame buffer after it is allocated via framebuffer_alloc, too.
> Therefore, in two failure cases the goto destination is changed to
> address this issue.
> 
> Fixes: c296d5f9957c ("staging: fbtft: core support")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@...il.com>

regards,
dan carpenter