linux-kernel - Re: [PATCH v2] loop: change queue block size to match when using DIO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c65da8b1-755c-57f5-d49d-fb25e8dc809b@kernel.dk>
Date:   Tue, 1 Oct 2019 08:10:10 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Martijn Coenen <maco@...roid.com>, hch@...radead.org,
        ming.lei@...hat.com
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, kernel-team@...roid.com,
        narayan@...gle.com, dariofreni@...gle.com, ioffe@...gle.com,
        jiyong@...gle.com, maco@...gle.com
Subject: Re: [PATCH v2] loop: change queue block size to match when using DIO.

On 9/4/19 1:49 PM, Martijn Coenen wrote:
> The loop driver assumes that if the passed in fd is opened with
> O_DIRECT, the caller wants to use direct I/O on the loop device.
> However, if the underlying block device has a different block size than
> the loop block queue, direct I/O can't be enabled. Instead of requiring
> userspace to manually change the blocksize and re-enable direct I/O,
> just change the queue block sizes to match, as well as the io_min size.

Applied, thanks.

-- 
Jens Axboe