linux-kernel - Re: [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0478d3aa-cc16-fabd-ece6-1392f9bdd850@intel.com>
Date:   Tue, 1 Oct 2019 09:07:21 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Thomas Hellstrom <thellstrom@...are.com>,
        Thomas Hellström (VMware) 
        <thomas_os@...pmail.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Pv-drivers <Pv-drivers@...are.com>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Christoph Hellwig <hch@...radead.org>,
        Christian König <christian.koenig@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page
 encryption bit

On 9/30/19 10:54 PM, Thomas Hellstrom wrote:
> Hi,
> 
> On 9/18/19 7:57 PM, Dave Hansen wrote:
>> On 9/17/19 6:01 AM, Thomas Hellström (VMware) wrote:
>>> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
>>> index b5e49e6bac63..8267dd426b15 100644
>>> --- a/arch/x86/include/asm/pgtable_types.h
>>> +++ b/arch/x86/include/asm/pgtable_types.h
>>> @@ -123,7 +123,7 @@
>>>   */
>>>  #define _PAGE_CHG_MASK	(PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT |		\
>>>  			 _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY |	\
>>> -			 _PAGE_SOFT_DIRTY | _PAGE_DEVMAP)
>>> +			 _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC)
>>>  #define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
>> My only nit with what remains is that it expands the infestation of
>> things that look like a simple macro but are not.
>>
>> I'm debating whether we want to go fix that now, though.
>>
> Any chance for an ack on this? It's really a small change that, as we've
> found out, fixes an existing problem.

Yes, feel free to add:

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>