linux-kernel - Re: [PATCH] ionic: select CONFIG_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191001.092455.1322622179723053160.davem@davemloft.net>
Date:   Tue, 01 Oct 2019 09:24:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     snelson@...sando.io, drivers@...sando.io, krzk@...nel.org,
        leon@...nel.org, kvalo@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ionic: select CONFIG_NET_DEVLINK

From: Arnd Bergmann <arnd@...db.de>
Date: Tue,  1 Oct 2019 16:21:40 +0200

> When no other driver selects the devlink library code, ionic
> produces a link failure:
> 
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
> ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
> ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
> 
> Add the same 'select' statement that the other drivers use here.
> 
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.