lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Oct 2019 07:04:30 +0100 From: "Lad, Prabhakar" <prabhakar.csengg@...il.com> To: Benoit Parrot <bparrot@...com> Cc: Hans Verkuil <hverkuil@...all.nl>, Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-media <linux-media@...r.kernel.org>, devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [Patch v5 4/8] media: i2c: ov2659: fix s_stream return value On Mon, Sep 30, 2019 at 2:07 PM Benoit Parrot <bparrot@...com> wrote: > > In ov2659_s_stream() return value for invoked function should be checked > and propagated. > > Signed-off-by: Benoit Parrot <bparrot@...com> > --- > drivers/media/i2c/ov2659.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com> Cheers, --Prabhakar Lad > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index f77320e8a60d..da181a13cf44 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -1187,11 +1187,15 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on) > goto unlock; > } > > - ov2659_set_pixel_clock(ov2659); > - ov2659_set_frame_size(ov2659); > - ov2659_set_format(ov2659); > - ov2659_set_streaming(ov2659, 1); > - ov2659->streaming = on; > + ret = ov2659_set_pixel_clock(ov2659); > + if (!ret) > + ret = ov2659_set_frame_size(ov2659); > + if (!ret) > + ret = ov2659_set_format(ov2659); > + if (!ret) { > + ov2659_set_streaming(ov2659, 1); > + ov2659->streaming = on; > + } > > unlock: > mutex_unlock(&ov2659->lock); > -- > 2.17.1 >
Powered by blists - more mailing lists