linux-kernel - Re: [PATCH 0/3] Pine64+ specific hacks for RTL8211E Ethernet PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ef60a0c-5cfd-420b-6cad-2c16eb2a6c01@gmail.com>
Date:   Tue, 1 Oct 2019 09:47:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Icenowy Zheng <icenowy@...c.io>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH 0/3] Pine64+ specific hacks for RTL8211E Ethernet PHY

On 10/1/19 1:29 AM, Icenowy Zheng wrote:
> There're some Pine64+ boards known to have broken RTL8211E chips, and
> a hack is given by Pine64+, which is said to be from Realtek.
> 
> This patchset adds the hack.
> 
> The hack is taken from U-Boot, and it contains magic numbers without
> any document.

Such hacks are the very reason why PHY fixups exists, please investigate
working with Realtek first to understand how to make this hack less of a
hack so it is understood what it does and you can either add proper
infrastructure to the realtek PHY driver to perform that hack, or if
that is not an option, register a board specific fixup.

> 
> Icenowy Zheng (3):
>   dt-bindings: add binding for RTL8211E Ethernet PHY
>   net: phy: realtek: add config hack for broken RTL8211E on Pine64+
>     boards
>   arm64: allwinner: a64: dts: apply hack for RTL8211E on Pine64+
> 
>  .../bindings/net/realtek,rtl8211e.yaml        | 23 +++++++++++++++++++
>  .../dts/allwinner/sun50i-a64-pine64-plus.dts  |  1 +
>  drivers/net/phy/realtek.c                     | 14 +++++++++++
>  3 files changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8211e.yaml
> 


-- 
Florian