linux-kernel - Re: [v6 PATCH] RISC-V: Remove unsupported isa string info print

Open Source and information security mailing list archives

Message-ID: <bc0d2f2803950ebb38fd487fddb0fcf8a370512e.camel@wdc.com>
Date:   Wed, 2 Oct 2019 06:28:59 +0000
From:   Atish Patra <Atish.Patra@....com>
To:     "hch@...radead.org" <hch@...radead.org>,
        "alankao@...estech.com" <alankao@...estech.com>
CC:     "anup@...infault.org" <anup@...infault.org>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "palmer@...ive.com" <palmer@...ive.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "johan@...nel.org" <johan@...nel.org>
Subject: Re: [v6 PATCH] RISC-V: Remove unsupported isa string info print

On Wed, 2019-10-02 at 09:53 +0800, Alan Kao wrote:
> On Tue, Oct 01, 2019 at 03:10:16AM -0700, hch@...radead.org wrote:
> > On Tue, Oct 01, 2019 at 08:22:37AM +0000, Atish Patra wrote:
> > > riscv_of_processor_hartid() or seems to be a better candidate. We
> > > already check if "rv" is present in isa string or not. I will
> > > extend
> > > that to check for rv64i or rv32i. Is that okay ?
> > 
> > I'd rather lift the checks out of that into a function that is
> > called
> > exactly once per hart on boot (and future cpu hotplug).
> 
@Christoph
Do you mean to lift the checks for "rv" as well from
riscv_of_processor_hartid as well or leave that as it is? 

> Sorry that I am a bit out of date on this.  Is there any related
> discussion about such checks?  

We are trying to remove all the checks in /proc/cpuinfo and just print
isa as it is. Here is the previous discussion.

http://lists.infradead.org/pipermail/linux-riscv/2019-
September/006702.html

> Just want to make sure if the check
> stops here and will not go any further for extensions, Xs and Zs.
> 

At least not here. I don't think we need to check for optional
extensions anywhere except in the extension relevant code.

> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv

-- 
Regards,
Atish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives