linux-kernel - Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191002081717.GA4015@kitsune.suse.cz>
Date:   Wed, 2 Oct 2019 10:20:06 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, alsa-devel@...a-project.org,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI

On Wed, Sep 04, 2019 at 05:10:59PM +0530, Vinod Koul wrote:
> On 04-09-19, 12:48, Michal Suchánek wrote:
> > On Wed, 4 Sep 2019 15:00:52 +0530
> > Vinod Koul <vkoul@...nel.org> wrote:
> > 
> > > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > > Fixes the following warning on !ACPI systems:
> > > > > 
> > > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > > not used [-Wunused-function]
> > > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > > >             ^~~~~~~~~~~~~
> > > > > 
> > > > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>  
> > > > 
> > > > Acked-by: Randy Dunlap <rdunlap@...radead.org>
> > > > 
> > > > I was about to send the same patch.  
> > > 
> > > So I have applied Srini's patches which add DT support and they use
> > > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > > used by DT parts as well.
> > > 
> > > So dropping this patch
> > > 
> > 
> > That should fix the issue for me. I wonder if !ACPI !DT platforms are
> > still a thing.
> 
> Heh that should trigger this if we have one :D so should a lot more
> which depend on some firmware!

Actually s390x is built with !ACPI and !OF. While it supports PCI an
virtio in practice only sound devices emulated by qemu are available.
Also AFAICT the sounwire driver is useless without ACPI or OF so it
should depend on them.

Thanks

Michal