linux-kernel - Re: [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 11:21:55 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     <t-kristo@...com>, <mturquette@...libre.com>
CC:     <sboyd@...nel.org>, <linux-omap@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call



On 26/09/2019 13.45, Peter Ujfalusi wrote:
> ti_clk_register() calls it already so the driver should not create
> duplicated alias.

This patch will leave 'ret' as unused in of_dra7_atl_clock_setup(), I'll
send v2 in a minute or so.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  drivers/clk/ti/clk-dra7-atl.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index a01ca9395179..c0e0ee974151 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -207,11 +207,6 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
>  	clk = ti_clk_register(NULL, &clk_hw->hw, node->name);
>  
>  	if (!IS_ERR(clk)) {
> -		ret = ti_clk_add_alias(NULL, clk, node->name);
> -		if (ret) {
> -			clk_unregister(clk);
> -			goto cleanup;
> -		}
>  		of_clk_add_provider(node, of_clk_src_simple_get, clk);
>  		kfree(parent_names);
>  		return;
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki