[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdaVhhGF-g_95zPg2wvXGcGfYG1YUVVuz5nOsRw8GwGQkw@mail.gmail.com>
Date: Wed, 2 Oct 2019 14:00:14 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Enrico Weigelt <info@...ux.net>,
Linux Input <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: ixp4xx-beeper: include linux/io.h
On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@...db.de> wrote:
> asm/io.h may not be included implicitly, causing a rare
> randconfig build error:
>
> drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]
> __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
I am thinking a bit about the future of this driver. Isn't it more
reasonable to just make a hrtimer-driven PWM and use the existing
PWM userspace ABI and timer framework in Linux for this?
Not that there is a generic timer-driven PWM but ... that is
essentially what this driver is.
Yours,
Linus Walleij
Powered by blists - more mailing lists