linux-kernel - Re: [PATCH v4] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 08:38:41 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     Michael Kelley <mikelley@...rosoft.com>,
        Wei Hu <weh@...rosoft.com>,
        "b.zolnierkie@...sung.com" <b.zolnierkie@...sung.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Iouri Tarassov <iourit@...rosoft.com>
Subject: Re: [PATCH v4] video: hyperv: hyperv_fb: Obtain screen resolution
 from Hyper-V host

On Fri, Sep 13, 2019 at 06:38:42AM +0000, Dexuan Cui wrote:
>> From: Michael Kelley <mikelley@...rosoft.com>
>> Sent: Thursday, September 5, 2019 7:06 AM
>>
>> From: Wei Hu <weh@...rosoft.com> Sent: Thursday, September 5, 2019 2:12
>> AM
>> >
>> > Beginning from Windows 10 RS5+, VM screen resolution is obtained from
>> host.
>> > The "video=hyperv_fb" boot time option is not needed, but still can be
>> > used to overwrite what the host specifies. The VM resolution on the host
>> > could be set by executing the powershell "set-vmvideo" command.
>> >
>> > Signed-off-by: Iouri Tarassov <iourit@...rosoft.com>
>> > Signed-off-by: Wei Hu <weh@...rosoft.com>
>> > ---
>> >     v2:
>> >     - Implemented fallback when version negotiation failed.
>> >     - Defined full size for supported_resolution array.
>> >
>> >     v3:
>> >     - Corrected the synthvid major and minor version comparison problem.
>> >
>> >     v4:
>> >     - Changed function name to synthvid_ver_ge().
>> >
>> >  drivers/video/fbdev/hyperv_fb.c | 159
>> +++++++++++++++++++++++++++++---
>> >  1 file changed, 147 insertions(+), 12 deletions(-)
>> >
>>
>> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
>
>Looks good to me.
>
>Reviewed-by: Dexuan Cui <decui@...rosoft.com>

Queued up for hyperv-next, thank you.

--
Thanks,
Sasha