linux-kernel - Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36766293-28b1-8903-bde8-5f04082c8b89@embeddedor.com>
Date:   Wed, 2 Oct 2019 08:32:18 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     "Liu, Leo" <Leo.Liu@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init



On 10/1/19 17:21, Liu, Leo wrote:

>>>> OK. So, maybe we can add a comment pointing that out?
>>> That could be better.
>>>
>> Great. I'm glad it's not a bug.  I'll write a patch for that so other
>> people don't waste time taking a look.
> 
> Thanks, just sent two patches to add comment, and long with the patch to 
> make VCN ring ready properly.
> 

Awesome. Thank you. I would just add a commit log to this patch:

[PATCH 2/2] drm/amdgpu: add a comment to VCN 2.5 encode ring

I'd update the subject to: drm/amdgpu: add code comment in vcn_v2_5_hw_init
and add this as a commit log: Add a comment to VCN 2.5 encode ring

Also, I think it's important to follow the process and CC all the people and lists
below:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
Alex Deucher <alexander.deucher@....com> (supporter:RADEON and AMDGPU DRM DRIVERS)
"Christian König" <christian.koenig@....com> (supporter:RADEON and AMDGPU DRM DRIVERS)
"David (ChunMing) Zhou" <David1.Zhou@....com> (supporter:RADEON and AMDGPU DRM DRIVERS)
David Airlie <airlied@...ux.ie> (maintainer:DRM DRIVERS)
Daniel Vetter <daniel@...ll.ch> (maintainer:DRM DRIVERS)
amd-gfx@...ts.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS)
dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS)
linux-kernel@...r.kernel.org (open list)

Thanks
--
Gustavo