linux-kernel - Re: [PATCH] drm/amdgpu: remove set but not used variable 'pipe'

Open Source and information security mailing list archives

Message-ID: <CADnq5_N9a+s5stOOX8QaMZXWJ680povytY975QvO0Eu7Y=UBYA@mail.gmail.com>
Date:   Wed, 2 Oct 2019 09:44:31 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     yu kuai <yukuai3@...wei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, yi.zhang@...wei.com,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, zhengbin13@...wei.com,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: remove set but not used variable 'pipe'

On Mon, Sep 30, 2019 at 3:03 AM yu kuai <yukuai3@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function
> ‘amdgpu_gfx_graphics_queue_acquire’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning:
> variable ‘pipe’ set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: yu kuai <yukuai3@...wei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index f9bef31..c1035a3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -231,12 +231,10 @@ void amdgpu_gfx_compute_queue_acquire(struct amdgpu_device *adev)
>
>  void amdgpu_gfx_graphics_queue_acquire(struct amdgpu_device *adev)
>  {
> -       int i, queue, pipe, me;
> +       int i, queue, me;
>
>         for (i = 0; i < AMDGPU_MAX_GFX_QUEUES; ++i) {
>                 queue = i % adev->gfx.me.num_queue_per_pipe;
> -               pipe = (i / adev->gfx.me.num_queue_per_pipe)
> -                       % adev->gfx.me.num_pipe_per_me;
>                 me = (i / adev->gfx.me.num_queue_per_pipe)
>                       / adev->gfx.me.num_pipe_per_me;
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives