linux-kernel - Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 17:48:35 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Jeroen Hofstee <jhofstee@...tronenergy.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
CC:     Koen Kooi <koen@...inion.thruhere.net>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet



On 02/10/2019 12:54, Jeroen Hofstee wrote:
> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke
> the ethernet networking on the beaglebone enhanced.

Above commit is incorrect (by itself) and there are few more commits on top of
it, so pls. update reference to commit(s)

bb0ce4c1517d net: phy: at803x: stop switching phy delay config needlessly
6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode


> 
> The board relied on the bug in the at803x driver to always enable the rx
> delay. So change the phy-mode to rgmii-id so it is enabled again.
> 
> Signed-off-by: Jeroen Hofstee <jhofstee@...tronenergy.com>
> cc: Koen Kooi <koen@...inion.thruhere.net>
> ---
>   arch/arm/boot/dts/am335x-sancloud-bbe.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> index 8678e6e35493..e5fdb7abb0d5 100644
> --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> @@ -108,7 +108,7 @@
>   
>   &cpsw_emac0 {
>   	phy-handle = <&ethphy0>;
> -	phy-mode = "rgmii-txid";
> +	phy-mode = "rgmii-id";
>   };
>   
>   &i2c0 {
> 

-- 
Best regards,
grygorii