linux-kernel - Re: [PATCH v1 5/5] staging: fieldbus: add support for HMS FL-NET industrial controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiXet4-2zUZ0oEO1iOqFM22zgVPZQ24Dzz5Q9TzTOTzjJQ@mail.gmail.com>
Date:   Wed, 2 Oct 2019 11:08:29 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Andreas Färber <afaerber@...e.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Enrico Weigelt <lkml@...ux.net>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        "J. Kiszka" <jan.kiszka@...mens.com>,
        Frank Iwanitz <friw@...-networks.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 5/5] staging: fieldbus: add support for HMS FL-NET
 industrial controller

On Mon, Sep 30, 2019 at 10:09 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> Discussing "patented" in a changelog text is a big no-no.  Please don't
> do that.  Talk to your corporate lawyers for why not...

Interesting. I will definitely have to investigate what's covered by those
patents.

>
> Why are you adding support for new things here?  New hardware support
> should _only_ be added once the code is out of staging, otherwise there
> is no pressure to get it out of this directory structure.
>

Because I am adding configuration support, and the existing supported h/w
does not require this to operate. So I thought it'd make sense to add at
least one in-kernel user of the new config interface.

Would it be a better strategy to add an (optional) config interface to the
existing supported h/w in staging/, rather than introducing new h/w ?