linux-kernel - Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191002153410.GO4106@piout.net>
Date:   Wed, 2 Oct 2019 17:34:10 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Dmitry Torokhov <dtor@...gle.com>
Cc:     Nick Crews <ncrews@...omium.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        Pavel Machek <pavel@....cz>, enric.balletbo@...labora.com,
        Benson Leung <bleung@...omium.org>, dlaurie@...omium.org,
        Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times

On 02/10/2019 08:20:34-0700, Dmitry Torokhov wrote:
> > I'm still not convinced it is useful to have an error in dmesg when the
> > time is invalid, as long as userspace knows it is invalid. What is the
> > course of action for the end user when that happens?
> 
> Report it, or, in our case, we will see it in the feedback logs.
> However I do agree that it is not the best option, even if we report
> error to userspace I am not sure if it will handle it properly. What
> userspace is supposed to do when presented with -EIO or similar?
> 

I would say probably retry a few times if it gets -EIO and simply abort
in case of -EINVAL. I'm not aware of any userspace tool behaving that
way though. They all simply abort.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com