linux-kernel - Re: [PATCH v10 00/16] Multicolor Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3092db49-04de-4a3d-1562-e4728f000e53@ti.com>
Date:   Wed, 2 Oct 2019 10:53:26 -0500
From:   Dan Murphy <dmurphy@...com>
To:     <jacek.anaszewski@...il.com>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 00/16] Multicolor Framework

Hello

On 10/1/19 9:56 AM, Dan Murphy wrote:
> Hello
>
> I have updated the code per v9 review comments
> https://lore.kernel.org/patchwork/project/lkml/list/?series=411824

I have a v11 version ready to go would like to include any v10 comments

So v11 changes include

- Adding inline MC framework functions for devices that do not have a 
direct dependency on the MC framework (ie LP55xx)

- Update and fixed the devm_* MC framework functions (fixed the struct 
in match and added the devm_*_ext functions)

- Removed the hard dependency on the MC framework in the Kconfig for the 
LP55xx_common code.

Dan


> Some notable changes:
>
> MC framework 4/16
>   - Added a color structure for device drivers to use to associate color IDs with
>   brightness values
>   - Name of structure may need some work but this is for proof of concept.
>   - Added back in the devm_* APIs
>   - Inlined function led_classdev_multicolor_register
>
> LP55xx
>   - Fixed binding doc to add "@" to nodes [8/16]
>   - Fixed associated DT file to add the "@" to each node [9,10,11/16]
>   - Separate the LP5523 code changes from the LP55xx common code change
>   - Added channel to color ID mapping for LP55xx [12/16]
>
> LP5523
>   - Separated out this code from LP55xx
>
> LP5521
>   - New patch adding multicolor framework support for this device
>
> Dan
>
> Dan Murphy (16):
>    dt: bindings: Add multicolor class dt bindings documention
>    dt-bindings: leds: Add multicolor ID to the color ID list
>    leds: Add multicolor ID to the color ID list
>    leds: multicolor: Introduce a multicolor class definition
>    dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
>    leds: lp50xx: Add the LP50XX family of the RGB LED driver
>    dt: bindings: lp55xx: Be consistent in the document with LED acronym
>    dt: bindings: lp55xx: Update binding for Multicolor Framework
>    ARM: dts: n900: Add reg property to the LP5523 channel node
>    ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
>    ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
>    leds: lp55xx: Add multicolor framework support to lp55xx
>    leds: lp5523: Update the lp5523 code to add intensity function
>    leds: lp5521: Add multicolor framework intensity support
>    leds: lp55xx: Fix checkpatch file permissions issues
>    leds: lp5523: Fix checkpatch issues in the code
>
>   .../ABI/testing/sysfs-class-led-multicolor    |  35 +
>   .../bindings/leds/leds-class-multicolor.txt   |  98 +++
>   .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++
>   .../devicetree/bindings/leds/leds-lp55xx.txt  | 155 +++-
>   Documentation/leds/index.rst                  |   1 +
>   Documentation/leds/leds-class-multicolor.rst  |  96 +++
>   arch/arm/boot/dts/imx6dl-yapp4-common.dtsi    |  14 +-
>   arch/arm/boot/dts/omap3-n900.dts              |  29 +-
>   arch/arm/boot/dts/ste-href.dtsi               |  22 +-
>   drivers/leds/Kconfig                          |  22 +
>   drivers/leds/Makefile                         |   2 +
>   drivers/leds/led-class-multicolor.c           | 268 ++++++
>   drivers/leds/led-core.c                       |   1 +
>   drivers/leds/leds-lp50xx.c                    | 784 ++++++++++++++++++
>   drivers/leds/leds-lp5521.c                    |  14 +
>   drivers/leds/leds-lp5523.c                    |  33 +-
>   drivers/leds/leds-lp55xx-common.c             | 191 ++++-
>   drivers/leds/leds-lp55xx-common.h             |  11 +
>   include/dt-bindings/leds/common.h             |   3 +-
>   include/linux/led-class-multicolor.h          |  88 ++
>   include/linux/platform_data/leds-lp55xx.h     |   6 +
>   21 files changed, 1928 insertions(+), 93 deletions(-)
>   create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
>   create mode 100644 Documentation/leds/leds-class-multicolor.rst
>   create mode 100644 drivers/leds/led-class-multicolor.c
>   create mode 100644 drivers/leds/leds-lp50xx.c
>   create mode 100644 include/linux/led-class-multicolor.h
>