linux-kernel - Re: [PATCH] wil6210: check len before memcpy() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191002172330.4D7A36115A@smtp.codeaurora.org>
Date:   Wed,  2 Oct 2019 17:23:29 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Denis Efremov <efremov@...ux.com>
Cc:     linux-wireless@...r.kernel.org, Denis Efremov <efremov@...ux.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        wil6210@....qualcomm.com, Maya Erez <merez@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>, stable@...r.kernel.org
Subject: Re: [PATCH] wil6210: check len before memcpy() calls

Denis Efremov <efremov@...ux.com> wrote:

> memcpy() in wmi_set_ie() and wmi_update_ft_ies() is called with
> src == NULL and len == 0. This is an undefined behavior. Fix it
> by checking "ie_len > 0" before the memcpy() calls.
> 
> As suggested by GCC documentation:
> "The pointers passed to memmove (and similar functions in <string.h>)
> must be non-null even when nbytes==0, so GCC can use that information
> to remove the check after the memmove call." [1]
> 
> [1] https://gcc.gnu.org/gcc-4.9/porting_to.html
> 
> Cc: Maya Erez <merez@...eaurora.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: stable@...r.kernel.org
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

2c840676be8f wil6210: check len before memcpy() calls

-- 
https://patchwork.kernel.org/patch/11168621/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches