linux-kernel - Re: [PATCH -next 2/2] leds: add /sys/class/leds/<led>/current-trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 20:06:25 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Dan Murphy <dmurphy@...com>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH -next 2/2] leds: add /sys/class/leds/<led>/current-trigger

Hi!

> >>>diff --git a/Documentation/ABI/testing/sysfs-class-led
> >>>b/Documentation/ABI/testing/sysfs-class-led
> >>>index 5f67f7a..fdfed3f 100644
> >>>--- a/Documentation/ABI/testing/sysfs-class-led
> >>>+++ b/Documentation/ABI/testing/sysfs-class-led
> >>>@@ -61,3 +61,16 @@ Description:
> >>>           gpio and backlight triggers. In case of the backlight trigger,
> >>>           it is useful when driving a LED which is intended to indicate
> >>>           a device in a standby like state.
> >>>+
> >>>+What:        /sys/class/leds/<led>/current-trigger
> >>>+Date:        September 2019
> >>>+KernelVersion:    5.5
> >>>+Contact:    linux-leds@...r.kernel.org
> >>>+Description:
> >>>+        Set the trigger for this LED. A trigger is a kernel based source
> >>>+        of LED events.
> >>>+        Writing the trigger name to this file will change the current
> >>>+        trigger. Trigger specific parameters can appear in
> >>>+        /sys/class/leds/<led> once a given trigger is selected. For
> >>>+        their documentation see sysfs-class-led-trigger-*.
> >>>+        Reading this file will return the current LED trigger name.
> >>Why do we need this new file can't we just update the current trigger
> >>file implementation?
> >We can't change existing ABI. It doesn't matter if it is documented
> >or not - it's in place for very long time and you can't guarantee there
> >are no users relying on triggers file show format.
> 
> So if it has been in place for a very long time why do we need another ABI
> that does sorta the same thing?
> 
> This seems to be a bit confusing and extra.

Agreed. Lets simply keep the existing ABI.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)