linux-kernel - Re: [PATCH] input: touchscreen: imx6ul_tsc: Use 'dev' instead of dereferencing it repeatedly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 07:32:42 +0200
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Anson Huang <Anson.Huang@....com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, swboyd@...omium.org, mojha@...eaurora.org,
        linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Linux-imx@....com
Subject: Re: [PATCH] input: touchscreen: imx6ul_tsc: Use 'dev' instead of
 dereferencing it repeatedly

On 01. 10. 19 1:08, Dmitry Torokhov wrote:
> On Tue, Sep 24, 2019 at 05:02:11PM +0800, Anson Huang wrote:
>> Add helper variable dev = &pdev->dev to simply the code.
> 
> Do we get any code savings from this?

I noticed Anson submitted similar patches into various other subsystems.
Here [1] is a very detailed response from David Laight shedding some light
on this topic.

[1] https://lkml.org/lkml/2019/9/24/151

>>
>> Signed-off-by: Anson Huang <Anson.Huang@....com>
>> ---
>>   drivers/input/touchscreen/imx6ul_tsc.c | 37 +++++++++++++++++-----------------
>>   1 file changed, 19 insertions(+), 18 deletions(-)