linux-kernel - Re: renaming FIELD_SIZEOF to sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191002.132121.402975401040540710.davem@davemloft.net>
Date:   Wed, 02 Oct 2019 13:21:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        pankaj.laxminarayan.bharadiya@...el.com, joe@...ches.com,
        adobriyan@...il.com, netdev@...r.kernel.org
Subject: Re: renaming FIELD_SIZEOF to sizeof_member

From: Kees Cook <keescook@...omium.org>
Date: Wed, 2 Oct 2019 11:19:16 -0700

> On Thu, Sep 26, 2019 at 01:56:55PM -0700, Kees Cook wrote:
>> On Thu, Sep 26, 2019 at 01:06:01PM -0700, Linus Torvalds wrote:
>> >  (a) why didn't this use the already existing and well-named macro
>> > that nobody really had issues with?
>> 
>> That was suggested, but other folks wanted the more accurate "member"
>> instead of "field" since a treewide change was happening anyway:
>> https://www.openwall.com/lists/kernel-hardening/2019/07/02/2
>> 
>> At the end of the day, I really don't care -- I just want to have _one_
>> macro. :)
>> 
>> >  (b) I see no sign of the networking people having been asked about
>> > their preferences.
>> 
>> Yeah, that's entirely true. Totally my mistake; it seemed like a trivial
>> enough change that I didn't want to bother too many people. But let's
>> fix that now... Dave, do you have any concerns about this change of
>> FIELD_SIZEOF() to sizeof_member() (or if it prevails, sizeof_field())?
> 
> David, can you weight in on this? Are you okay with a mass renaming of
> FIELD_SIZEOF() to sizeof_member(), as the largest user of the old macro
> is in networking?

I have no objection to moving to sizeof_member().