linux-kernel - Re: [PATCH 3.16 29/87] staging: iio: cdc: Don't put an else right after a return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 02 Oct 2019 14:36:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        Catalina Mocanu <catalina.mocanu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3.16 29/87] staging: iio: cdc: Don't put an else right
 after a return

On Wed, 2019-10-02 at 20:06 +0100, Ben Hutchings wrote:
> 3.16.75-rc1 review patch.  If anyone has any objections, please let me know.

This doesn't look necessary.

> ------------------
> 
> From: Catalina Mocanu <catalina.mocanu@...il.com>
> 
> commit 288903f6b91e759b0a813219acd376426cbb8f14 upstream.
> 
> This fixes the following checkpatch.pl warning:
> WARNING: else is not generally useful after a break or return.
> 
> While at it, remove new line for symmetry with the rest of the code.
> 
> Signed-off-by: Catalina Mocanu <catalina.mocanu@...il.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  drivers/staging/iio/cdc/ad7150.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -143,19 +143,15 @@ static int ad7150_read_event_config(stru
>  	case IIO_EV_TYPE_MAG_ADAPTIVE:
>  		if (dir == IIO_EV_DIR_RISING)
>  			return adaptive && (threshtype == 0x1);
> -		else
> -			return adaptive && (threshtype == 0x0);
> +		return adaptive && (threshtype == 0x0);
>  	case IIO_EV_TYPE_THRESH_ADAPTIVE:
>  		if (dir == IIO_EV_DIR_RISING)
>  			return adaptive && (threshtype == 0x3);
> -		else
> -			return adaptive && (threshtype == 0x2);
> -
> +		return adaptive && (threshtype == 0x2);
>  	case IIO_EV_TYPE_THRESH:
>  		if (dir == IIO_EV_DIR_RISING)
>  			return !adaptive && (threshtype == 0x1);
> -		else
> -			return !adaptive && (threshtype == 0x0);
> +		return !adaptive && (threshtype == 0x0);
>  	default:
>  		break;
>  	}
>