linux-kernel - Re: [PATCH v9 2/5] dma-buf: heaps: Add heap helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLX7JgUvixQQMn=6thfhOg_Bw1fN02KQPkO9144yRwPwMw@mail.gmail.com>
Date:   Wed, 2 Oct 2019 15:27:41 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, lkml <linux-kernel@...r.kernel.org>,
        Laura Abbott <labbott@...hat.com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Liam Mark <lmark@...eaurora.org>,
        Pratik Patel <pratikp@...eaurora.org>,
        Brian Starkey <Brian.Starkey@....com>,
        Vincent Donnefort <Vincent.Donnefort@....com>,
        Sudipto Paul <Sudipto.Paul@....com>,
        "Andrew F . Davis" <afd@...com>,
        Christoph Hellwig <hch@...radead.org>,
        Chenbo Feng <fengc@...gle.com>,
        Alistair Strachan <astrachan@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>,
        Hillf Danton <hdanton@...a.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v9 2/5] dma-buf: heaps: Add heap helpers

On Wed, Oct 2, 2019 at 3:10 PM kbuild test robot <lkp@...el.com> wrote:
>
> Hi John,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.4-rc1 next-20191002]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url:    https://github.com/0day-ci/linux/commits/John-Stultz/DMA-BUF-Heaps-destaging-ION/20191003-042849
> config: mips-allmodconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/dma-buf/heaps/heap-helpers.c: In function 'dma_heap_map_kernel':
> >> drivers/dma-buf/heaps/heap-helpers.c:43:10: error: implicit declaration of function 'vmap'; did you mean 'bmap'? [-Werror=implicit-function-declaration]
>      vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
>              ^~~~
>              bmap
> >> drivers/dma-buf/heaps/heap-helpers.c:43:49: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MPX'?
>      vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
>                                                     ^~~~~~
>                                                     VM_MPX


Ah, looks like I'm missing:
+#include <linux/vmalloc.h>

Which somehow gets pulled in through the headers on other arches.

I'll fix that up. Thanks so much!
-john