linux-kernel - Re: [PATCH net] net: stmmac: Avoid deadlock on suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191002.172213.1475260023258384833.davem@davemloft.net>
Date:   Wed, 02 Oct 2019 17:22:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     thierry.reding@...il.com
Cc:     joabreu@...opsys.com, alexandre.torgue@...com,
        peppe.cavallaro@...com, f.fainelli@...il.com, bbiswas@...dia.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: stmmac: Avoid deadlock on suspend/resume

From: Thierry Reding <thierry.reding@...il.com>
Date: Wed,  2 Oct 2019 16:49:46 +0200

> From: Thierry Reding <treding@...dia.com>
> 
> The stmmac driver will try to acquire its private mutex during suspend
> via phylink_resolve() -> stmmac_mac_link_down() -> stmmac_eee_init().
> However, the phylink configuration is updated with the private mutex
> held already, which causes a deadlock during suspend.
> 
> Fix this by moving the phylink configuration updates out of the region
> of code protected by the private mutex.
> 
> Fixes: 19e13cb27b99 ("net: stmmac: Hold rtnl lock in suspend/resume callbacks")
> Suggested-by: Bitan Biswas <bbiswas@...dia.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>

Applied.