[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d091d361b0233da07f45488aae87857cb9388529.camel@intel.com>
Date: Thu, 3 Oct 2019 17:06:06 +0000
From: "Derrick, Jonathan" <jonathan.derrick@...el.com>
To: "rdunlap@...radead.org" <rdunlap@...radead.org>,
"sbauer@...donthack.me" <sbauer@...donthack.me>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"Rajashekar, Revanth" <revanth.rajashekar@...el.com>,
"axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH 2/2] block: sed-opal: fix sparse warning: convert __be64
data
On Thu, 2019-10-03 at 11:40 -0400, Scott Bauer wrote:
> On Wed, Oct 02, 2019 at 07:23:15PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@...radead.org>
> >
> > sparse warns about incorrect type when using __be64 data.
> > It is not being converted to CPU-endian but it should be.
> >
> > Fixes these sparse warnings:
> >
> > ../block/sed-opal.c:375:20: warning: incorrect type in assignment (different base types)
> > ../block/sed-opal.c:375:20: expected unsigned long long [usertype] align
> > ../block/sed-opal.c:375:20: got restricted __be64 const [usertype] alignment_granularity
> > ../block/sed-opal.c:376:25: warning: incorrect type in assignment (different base types)
> > ../block/sed-opal.c:376:25: expected unsigned long long [usertype] lowest_lba
> > ../block/sed-opal.c:376:25: got restricted __be64 const [usertype] lowest_aligned_lba
> >
> > Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Scott Bauer <scott.bauer@...el.com>
> > Cc: Rafael Antognolli <rafael.antognolli@...el.com>
> > Cc: Jens Axboe <axboe@...nel.dk>
> > Cc: linux-block@...r.kernel.org
>
> + Jon and Revanth,
>
>
> These look fine. They're currently unused, but may be useful in the future for sysfs or what ever else we add in.
I imagine modern devices with logical/physical indirection would
probably report gran=1 and lowest=0 regardless.
Either way,
Reviewed-by: Jon Derrick <jonathan.derrick@...el.com>
Powered by blists - more mailing lists