linux-kernel - Re: [PATCH] fs: cifs: mute -Wunused-const-variable message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Oct 2019 13:57:29 -0500
From:   Steve French <smfrench@...il.com>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: cifs: mute -Wunused-const-variable message

merged into cifs-2.6.git for-next

On Tue, Oct 1, 2019 at 2:34 AM Austin Kim <austindh.kim@...il.com> wrote:
>
> After 'Initial git repository build' commit,
> 'mapping_table_ERRHRD' variable has not been used.
>
> So 'mapping_table_ERRHRD' const variable could be removed
> to mute below warning message:
>
>    fs/cifs/netmisc.c:120:40: warning: unused variable 'mapping_table_ERRHRD' [-Wunused-const-variable]
>    static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
>                                            ^
> Signed-off-by: Austin Kim <austindh.kim@...il.com>
> ---
>  fs/cifs/netmisc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index 49c17ee1..9b41436 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -117,10 +117,6 @@ static const struct smb_to_posix_error mapping_table_ERRSRV[] = {
>         {0, 0}
>  };
>
> -static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
> -       {0, 0}
> -};
> -
>  /*
>   * Convert a string containing text IPv4 or IPv6 address to binary form.
>   *
> --
> 2.6.2
>


-- 
Thanks,

Steve