linux-kernel - Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003190651.GB21875@lunn.ch>
Date:   Thu, 3 Oct 2019 21:06:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        open list <linux-kernel@...r.kernel.org>, hkallweit1@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        manasa.mudireddy@...adcom.com, ray.jui@...adcom.com,
        olteanv@...il.com, rafal@...ecki.pl
Subject: Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

On Thu, Oct 03, 2019 at 11:55:40AM -0700, Florian Fainelli wrote:
> Hi Andrew,
> 
> On 10/3/19 11:51 AM, Andrew Lunn wrote:
> > On Thu, Oct 03, 2019 at 11:43:50AM -0700, Florian Fainelli wrote:
> >> Hi all,
> >>
> >> This patch series fixes the BCM54210E RGMII delay configuration which
> >> could only have worked in a PHY_INTERFACE_MODE_RGMII configuration.
> > 
> > Hi Florian
> > 
> > So any DT blob which incorrectly uses one of the other RGMII modes is
> > now going to break, where as before it was ignored.
> 
> Potentially yes. There is a precedent with the at803x PHY driver

Hi Florian

Yes that was an interesting learning experience. I'm not sure we want
to do that again. A lot of devices broken, and a lot of people were
unhappy.

If we are looking at a similar scale of breakage, i think i would
prefer to add a broadcom,bcm54210e-phy-mode property in the DT which
if present would override the phy_interface_t passed to the driver.

   Andrew