linux-kernel - Re: [PATCH v8 2/5] leds: Add of_led_get() and led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Oct 2019 21:21:06 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Jean-Jacques Hiblot <jjhiblot@...com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        pavel@....cz, robh+dt@...nel.org, mark.rutland@....com,
        lee.jones@...aro.org, daniel.thompson@...aro.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        tomi.valkeinen@...com, dmurphy@...com, linux-leds@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put()

Hi Mark,

On 10/3/19 8:35 PM, Mark Brown wrote:
> On Thu, Oct 03, 2019 at 07:43:17PM +0200, Jacek Anaszewski wrote:
>> On 10/3/19 2:47 PM, Jean-Jacques Hiblot wrote:
>>> On 03/10/2019 12:42, Sebastian Reichel wrote:
>>>> On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote:
> 
> This mail has nothing relevant in the subject line and pages of quotes
> before the question for me, it's kind of lucky I noticed it....

Isn't it all about creating proper filters?

>> I wonder if it wouldn't make sense to add support for fwnode
>> parsing to regulator core. Or maybe it is either somehow supported
>> or not supported on purpose?
> 
> Anything attempting to use the regulator DT bindings in ACPI has very
> serious problems, ACPI has its own power model which isn't compatible
> with that used in DT.

We have a means for checking if fwnode refers to of_node:

is_of_node(const struct fwnode_handle *fwnode)

Couldn't it be employed for OF case?

-- 
Best regards,
Jacek Anaszewski