linux-kernel - Re: [PATCH] mm/slub: fix a deadlock in show_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1570133266.5576.268.camel@lca.pw>
Date:   Thu, 03 Oct 2019 16:07:46 -0400
From:   Qian Cai <cai@....pw>
To:     David Rientjes <rientjes@...gle.com>
Cc:     akpm@...ux-foundation.org, cl@...ux.com, penberg@...nel.org,
        tj@...nel.org, vdavydov.dev@...il.com, hannes@...xchg.org,
        guro@...com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: fix a deadlock in show_slab_objects()

On Thu, 2019-10-03 at 12:56 -0700, David Rientjes wrote:
> On Thu, 3 Oct 2019, Qian Cai wrote:
> 
> > diff --git a/mm/slub.c b/mm/slub.c
> > index 42c1b3af3c98..922cdcf5758a 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -4838,7 +4838,15 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
> >  		}
> >  	}
> >  
> > -	get_online_mems();
> > +/*
> > + * It is not possible to take "mem_hotplug_lock" here, as it has already held
> > + * "kernfs_mutex" which could race with the lock order:
> > + *
> > + * mem_hotplug_lock->slab_mutex->kernfs_mutex
> > + *
> > + * In the worest case, it might be mis-calculated while doing NUMA node
> > + * hotplug, but it shall be corrected by later reads of the same files.
> > + */
> >  #ifdef CONFIG_SLUB_DEBUG
> >  	if (flags & SO_ALL) {
> >  		struct kmem_cache_node *n;
> 
> No objection to removing the {get,put}_online_mems() but the comment 
> doesn't match the kernel style.  I actually don't think we need the 
> comment at all, actually.

I am a bit worry about later someone comes to add the lock back as he/she
figures out that it could get more accurate statistics that way, but I agree it
is probably an overkill.

> 
> > @@ -4879,7 +4887,6 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
> >  			x += sprintf(buf + x, " N%d=%lu",
> >  					node, nodes[node]);
> >  #endif
> > -	put_online_mems();
> >  	kfree(nodes);
> >  	return x + sprintf(buf + x, "\n");
> >  }